add Dockerfile and GitHub action for building image #63
Conversation
willnorris
force-pushed
the
will/dockerfile
branch
2 times, most recently
from
5e15b1a to
6ce2c3e
Compare
|
wow, 16 minutes to build the image for two platforms :( |
There was a problem hiding this comment.
Makes sense in general, I've left two suggestions.
I think ko would be faster than Docker build, but it seems like it is not possible to expose ports using ko ko-build/ko#472
| labels: ${{ steps.meta.outputs.labels }} | ||
| platforms: linux/amd64,linux/arm64 | ||
|
|
||
| # Sign the Docker image |
Dockerfile
Outdated
| RUN go install github.com/caddyserver/xcaddy/cmd/xcaddy@latest && \ | ||
| xcaddy build v${CADDY_VERSION} --with github.com/tailscale/caddy-tailscale@main --output /usr/bin/caddy |
There was a problem hiding this comment.
| RUN go install github.com/caddyserver/xcaddy/cmd/xcaddy@latest && \ | |
| xcaddy build v${CADDY_VERSION} --with github.com/tailscale/caddy-tailscale@main --output /usr/bin/caddy | |
| RUN go run github.com/caddyserver/xcaddy/cmd/xcaddy@latest build v${CADDY_VERSION} \ | |
| --with github.com/tailscale/caddy-tailscale@main --output /usr/bin/caddy |
maybe makes it a little faster?
There was a problem hiding this comment.
Also, I'm wondering if we can use the tailscale-caddy repo checkout available to this action rather than refer to github.com/tailscale/caddy-tailscale@main? The checkout should presumably bet the one corresponding to the push event
There was a problem hiding this comment.
I'd be surprised if go run was actually any faster, but certainly doesn't hurt so let's give it a try.
And oops, totally forgot to instruct it to use the local source for building. I'll add that.
EXPOSE is really just to document what ports are exposed mapped, right? But it's not really necessary to be able to map ports? It also looks like ko really wants a simple main package that it can build. That would mean bypassing xcaddy entirely for our builds and having our own simple cmd. Which is totally fine, that's actually what I do for my personal website. I'll actually do that first as a separate PR. |
willnorris
force-pushed
the
will/dockerfile
branch
from
6ce2c3e to
e33ea0f
Compare
We also have our own container builder that is a stripped down version of ko and that allows to include multiple binaries https://github.com/tailscale/mkctr. |
That is my understanding, yes. Also, we don't expose ports for any of the other images we build (for example the k8s-operator that runs a server and listens on 443 and the tsrecorder) |
|
Hey, Can I help u too get this merged? I have some ideas how to make the pipeline faster, if that is the blocking thing :) |
heh, I think I honestly forgot this PR was out there! 😄 I think when I switched this back to a draft PR, it was because I was going to setup the separate main package, so then we could use ko to build? I'll try and find some time to work on that this week. What ideas did you have about making the pipeline faster? |
|
just let go handle the cross compiling, see docker blog post :) did that last week here too :) muety/wakapi#781 |
This largely mirrors the default Caddy image. Updates #14 Signed-off-by: Will Norris <will@tailscale.com>
willnorris
force-pushed
the
will/dockerfile
branch
from
e33ea0f to
78216bf
Compare
|
okay, rebased onto main and am now using I tried to build with ko, but I'm finding that it's juts too opinionated and limiting. It also uses the chainguard base image which dropped support for arm7 last year. I still want to be able to support previous generation raspberry pis, so am building on top of alpine instead. (We changed golink for similar reasons). |
This largely mirrors the default Caddy image. (I generally use chainguard images to limit dependencies, but stuck with alpine, since that's what Caddy uses for it's main images)
The GitHub Action is duplicated from what we have for
tailscale/golink. I don't really know a lot of best practices for Dockerfiles, so am really looking for any input. I have this using thesimple.caddyfileas the default config, which is easy to override.Updates #14